swactor/crates/engine/src/tokio.rs

147 lines
5.4 KiB
Rust
Raw Normal View History

feat(engine): substrate-neutral execution engine abstraction Introduce the swactor engine: a swactor-owned composite that retains a selected execution substrate, drives the core runtime, and hosts the async/blocking/timer work that backs actors. Integrations receive one cloneable EngineHandle and never construct or borrow a raw Tokio runtime/handle. Engine crate (crates/engine): - The contract: spawn / spawn_blocking / timer / interval / now, a per-implementation capability model with construction-time binding (require()), and engine-owned time. The engine owns all progression; actor handlers stay synchronous and never .await. - TokioBackend owns the Tokio runtime and schedules core ticks and supporting futures on it; SteppingBackend is a single-threaded deterministic scheduler with virtual time (the non-Tokio portability proof). Core is driven through its existing tick() surface; a self-rescheduling CoreDriver is installed at construction and is the sole place permitted to call try_tick. iroh-driver: - Receives an EngineHandle instead of a raw Tokio Handle. Accepts, reads, dials, writes, endpoint construction, and teardown schedule through it; required capabilities (tasks/timers/io) are validated before the endpoint binds. Engine-hosted interval pumps drive actor-bridge, datastream, and edge ingress. myelin: - One node/orchestrator engine owns core, protocol tick injection, and transport progression; the application loop only drains integration-owned queues. Stage-shard process readers, delayed actor messages, helper stdout/stderr, prompt RPC, and CPU sampling all schedule through the engine (spawn_blocking / engine tasks / timers). - Removed the split-engine APIs: install_actor_bridge_pump(period) and spawn_protocol_ticker(period) use each component's stored engine; deleted the no-op pump_network callback and its plumbing; deleted the dashboard raw-Tokio/standalone-runtime conveniences. Enforcement: - A clippy disallowed-methods boundary forbids direct runtime/scheduling/ time/core-driving bypasses, denied in swactor-engine, iroh-driver, and myelin. Retained excluded uses (VastAI provider, provider process supervision/log capture, OS-signal/stdin/process-control sequencing) carry narrow allowances with reasons. Verification: - Engine contract + unit tests (incl. the SteppingBackend portability proof), iroh integration tests (capability rejection before binding, multi-node actor behavior), and a production execution-composition smoke test that observes engine-driven actor progress with no ambient Tokio runtime and no manual tick/pump. Workspace all-target/all-feature clippy and tests are green. Specs co-located with their crates: ENGINE_SPEC.md in crates/engine, IROH_DRIVER_SPEC.md in crates/iroh-driver. VastAI remains explicitly out of scope pending its separate redesign.
2026-08-10 20:23:03 +00:00
//! Native Tokio execution backend.
//!
//! Owns a Tokio multi-threaded runtime whose `Handle` stays private. The
//! [`ExecutionBackend`](crate::ExecutionBackend) impl schedules cooperative
//! work onto that runtime; the `Handle` is never exposed through
//! [`EngineHandle`](crate::EngineHandle).
use std::future::Future;
use std::pin::Pin;
use std::task::{Context, Poll};
use std::time::{Duration, Instant};
use crate::backend::{BoxTask, BoxTimer, BoxWork, Capabilities, EngineError, ExecutionBackend};
use crate::time::EngineInstant;
/// Configuration for [`TokioBackend`].
#[derive(Debug, Clone, Copy)]
pub struct TokioConfig {
/// Number of async worker threads backing the runtime.
pub worker_threads: usize,
}
impl Default for TokioConfig {
fn default() -> Self {
Self { worker_threads: 2 }
}
}
/// An [`ExecutionBackend`](crate::ExecutionBackend) backed by an owned Tokio
/// multi-threaded runtime.
///
/// The runtime's `Handle` is never exposed through
/// [`EngineHandle`](crate::EngineHandle).
pub struct TokioBackend {
pub(crate) runtime: tokio::runtime::Runtime,
}
impl TokioBackend {
/// Build a backend with its own Tokio runtime tuned by `config`.
///
/// The runtime is owned and self-driving: its worker threads start at
/// construction, so spawned tasks progress without an ambient runtime or a
/// `block_on` driver. Tokio cancels spawned tasks (including the
/// core-driving loop) on `Runtime::drop`, so dropping the backend is
/// deterministic.
// The engine's Tokio backend is the substrate owner: it is the one place
// permitted to construct a Tokio runtime (ENGINE_SPEC.md §2).
#[allow(clippy::disallowed_methods)]
pub fn new(config: TokioConfig) -> Result<Self, EngineError> {
let runtime = tokio::runtime::Builder::new_multi_thread()
.worker_threads(config.worker_threads)
.enable_all()
.build()
.map_err(|e| EngineError::BackendSetup(e.to_string()))?;
Ok(Self { runtime })
}
/// Adopt a caller-tuned Tokio runtime, moving it into engine ownership.
pub fn from_runtime(runtime: tokio::runtime::Runtime) -> Self {
Self { runtime }
}
}
/// This impl is the Tokio substrate implementor: it is the one place permitted
/// to schedule directly on the owned runtime (ENGINE_SPEC.md §2).
#[allow(clippy::disallowed_methods)]
impl ExecutionBackend for TokioBackend {
fn spawn(&self, task: BoxTask) {
// The handle is used ephemerally and never stored or returned.
self.runtime.handle().spawn(task);
}
fn spawn_blocking(&self, work: BoxWork) {
// Routed onto the runtime's dedicated blocking pool — separate from
// the async worker threads — so blocking work cannot starve actor
// ticks (ENGINE_SPEC.md §8 progress independence).
self.runtime.handle().spawn_blocking(work);
}
fn timer(&self, delay: Duration) -> BoxTimer {
// Construct the `tokio::time::sleep` lazily on first poll rather than
// here: `EngineHandle::timer` may be called outside the runtime
// (ENGINE_SPEC.md §7), but `tokio::time::sleep` needs the time driver
// at construction. First poll runs inside an engine task where the
// driver is available. See `LazySleep`.
Box::pin(LazySleep::new(delay))
}
fn now(&self) -> EngineInstant {
EngineInstant { instant: Instant::now() }
}
fn capabilities(&self) -> Capabilities {
// The substrate physically provides tasks, timers, blocking, and I/O.
// `enable_all()` starts both the I/O reactor and the time driver, so
// advertising `io: true` is truthful — integrations such as Iroh rely
// on the native Tokio I/O environment (ENGINE_SPEC.md §6/§9).
Capabilities {
tasks: true,
timers: true,
blocking: true,
io: true,
}
}
}
/// A `tokio::time::sleep` whose construction is deferred to first poll.
///
/// `EngineHandle::timer` may be called outside the substrate runtime
/// (ENGINE_SPEC.md §7: creating a timer must not require entering or possessing
/// the runtime). `tokio::time::sleep` itself needs the time driver at
/// construction and panics ("there is no reactor running") when built outside a
/// Tokio context. This wrapper holds only the delay until first poll, which
/// runs inside an engine task where the driver is available, then builds and
/// delegates to the real `Sleep`.
struct LazySleep {
delay: Option<Duration>,
inner: Option<Pin<Box<tokio::time::Sleep>>>,
}
impl LazySleep {
fn new(delay: Duration) -> Self {
Self { delay: Some(delay), inner: None }
}
}
// `LazySleep` arms a `tokio::time::sleep` inside an engine task where the time
// driver is available; this is the substrate's own time primitive.
#[allow(clippy::disallowed_methods)]
impl Future for LazySleep {
type Output = ();
fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
// `LazySleep` is `Unpin`: both fields (`Option<Duration>` and
// `Option<Pin<Box<_>>>`) are `Unpin`, so `get_mut` is sound.
let this = self.get_mut();
if let Some(delay) = this.delay.take() {
this.inner = Some(Box::pin(tokio::time::sleep(delay)));
}
this.inner
.as_mut()
.expect("LazySleep polled after completion")
.as_mut()
.poll(cx)
}
}